nervosnetwork / fiber

15 stars 8 forks source link

uniform type name capitalization in JSON #109

Open doitian opened 2 months ago

doitian commented 2 months ago

Side note: there are many other places where we want to deserialize a string into a enum. Some of they are case insensitive (e.g. https://github.com/nervosnetwork/cfn-node/blob/c69f8121f9a542ddeae4d38e467234024ec92c8f/src/ckb_chain/config.rs#L108-L114 ), some of they are case sensitive, some of they just use the default serde config (e.g. https://github.com/nervosnetwork/cfn-node/blob/c69f8121f9a542ddeae4d38e467234024ec92c8f/src/ckb/config.rs#L127-L129). This can create confusion. We may want to unify all these serialization/deserialization procedures.

_Originally posted by @contrun in https://github.com/nervosnetwork/cfn-node/pull/105#discussion_r1658263975_