nervosnetwork / neuron

Neuron: Nervos CKB Wallet
https://www.nervos.org
MIT License
187 stars 82 forks source link

[Enhance User Experience] Automatically fill all blank when paste the complete recovery phrase. #3115

Closed yangby-cryptape closed 3 weeks ago

yangby-cryptape commented 5 months ago

Description

Recently, I have tried many wallets.

I found that most of them have a good feature: when a user pastes a complete secret recovery phrase into the wallet, all corresponding blank will be filled automatically.

But in Neuron, I have to paste each word into the corresponding blank one by one.

Comparison

Click HERE to the the comparison. - MetaMask ![MetaMask](https://github.com/nervosnetwork/neuron/assets/30993023/3b9d9aa9-fd37-45c0-8bb1-ce5f87850919) - Neuron ![Neuron](https://github.com/nervosnetwork/neuron/assets/30993023/3076f3f7-49f8-463c-adda-3abdd98b1041)

Another Issue

Neuron doesn't hide the secret recovery phrase after input.

yanguoyu commented 5 months ago

For better safety, we remove the copy-and-paste phrase seeds. If you copy your phrase seeds once, other unsafety apps may read your clipboard. So it's better to enter phrase seed words one by one.

yangby-cryptape commented 5 months ago

For better safety ...

Although you blame the problem on security, but Neuron doesn't hide words after them been input.

If you copy your phrase seeds once, other unsafety apps may read your clipboard. So it's better to enter phrase seed words one by one.

yangby-cryptape commented 5 months ago

If Neuron really wants to disable password leak via clipboard, don't use input fields.

A better solution is:

:point_right: If users don't see any input field, they won't try to copy-and-paste.

p.s. Since Neuron so cares about security :thumbsup:, I guess I could expect this feature finished in the next 2 or 3 releases :wink:; so excited, I can't wait for that.

Keith-CY commented 5 months ago

If Neuron wants to avoid password leak via the clipboard, Neuron should disable copy rather than disable paste.

Agreed, please have a consideration @Danie0918

The suggestion at https://github.com/nervosnetwork/neuron/issues/3115#issuecomment-2048796731 is a bit further.

I would suggest optimization as follows

  1. Disable the copy function of the mnemonics;
  2. Fill words into each field when the wallet is imported by pasting mnemonics;
  3. Display options along with characters being inputted, e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/datalist
  4. Leave some fields empty(not all fields empty) when a user inputs the mnemonics a second time for confirmation. By doing so, users have to write down all words but only need to type some of them.
github-actions[bot] commented 3 months ago

Mark this issue stale because no activity for 60 days

Danie0918 commented 3 months ago

WIP https://github.com/Magickbase/neuron-public-issues/issues/381

github-actions[bot] commented 1 month ago

Mark this issue stale because no activity for 60 days

github-actions[bot] commented 3 weeks ago

Close this issue because it's inactive since marked stale