search

nervosnetwork / polyjuice-provider

Godwoken-Polyjuice compatible providers for ethereum library
https://www.npmjs.com/org/polyjuice-provider
8 stars 14 forks source link

Bump Lumos for improved M1 Macs support. #41

Closed e00dan closed 3 years ago

e00dan commented 3 years ago

This PR is required so godwoken-examples or any repository using polyjuice-provider as dependency can run on Mac M1.

cc @RetricSu

RetricSu commented 3 years ago

just curious, I am using M1 to develop this repo, and this example. I did not realized the lumos unsupported issue. what's the expected result for this? Maybe I have different setup on my machine?

e00dan commented 3 years ago

@RetricSu

I'm not sure, but on Mac M1 Mini you can't install polyjuice-provider as dependency, because it depends on old lumos with cpu restriction.

image

You can see it is true by looking at polyjuice-provider yarn.lock file: https://github.com/nervosnetwork/polyjuice-provider/blob/main/yarn.lock#L174

Maybe it works for you because you have a workaround on your system (Example workaround: https://www.jurnalanas.com/node-js-mac-m1/)

image

RetricSu commented 3 years ago

yeap, indeed it is that arch workaround. will release a new version after this pr merged.

e00dan commented 3 years ago

@RetricSu

Okay, leaving review and merging to you.