search

nervous-systems / fink-nottle

Asynchronous Clojure/Clojurescript client for Amazon's SNS & SQS services
The Unlicense
48 stars 4 forks source link

Apply dropping buffer to error-chan when batching #13

Closed joelittlejohn closed 8 years ago

joelittlejohn commented 8 years ago

This changes avoids the situation where an error appearing on error-chan will block puts on the in-chan until it is is consumed.

@moea I'm not super happy with the way I've structured the test here, it feels like a bit of a hack to me (although it works correctly) :D

Feel free to suggest changes/improvements/refactorings. Cheers!

joelittlejohn commented 8 years ago

Sorry, I've just realised I haven't pushed the latest here. Hold off on checking this out :)

joelittlejohn commented 8 years ago

@moea Okay, I'm happy with this PR now. I've improved the test significantly.

The build is currently failing but I don't think this is related to this PR.

moea commented 8 years ago

Thanks! I'll push 0.4.7-SNAPSHOT shortly, and update the wiki.

(The build is failing because use of the encrypted env vars (AWS creds) is limited to in-repository PRs, I believe).

moea commented 8 years ago

Pushed

joelittlejohn commented 8 years ago

Thanks man, much appreciated :+1:

On 14 December 2015 at 18:48, Moe Aboulkheir notifications@github.com wrote:

Pushed

— Reply to this email directly or view it on GitHub https://github.com/nervous-systems/fink-nottle/pull/13#issuecomment-164523427 .