nervous-systems / serverless-cljs-plugin

Serverless plugin for Clojurescript deployment w/ cljs-lambda
The Unlicense
75 stars 10 forks source link

Cljs plugin does not exclude dev dependencies #28

Open arichiardi opened 7 years ago

arichiardi commented 7 years ago

I have run against this problem a couple of times now and this I have decided to investigate.

So given that we are not using the zipService provided by the Serverless Framework to zip up our stuff we don't mimic (I guess by design) its standard behavior. That's unfortunate.

There are two solutions to this (but maybe more, open to suggestions):

I think option one is more work but also probably the right thing to do, but I am also wondering if there is a way not to skip the packaging step (just provide a custom zip name to it).

Any other idea?

arichiardi commented 7 years ago

I actually see that if the compiler just does its job of copying the files in the root of the project, Serverless will just pick it up and zip itself. So my question is now, what am I missing? Why is this plugin doing the zipping?

arichiardi commented 7 years ago

Ok so I think I found out why, PR coming.

ckirkendall commented 6 years ago

Any update on this? I am seeing this issue today. @arichiardi

arichiardi commented 6 years ago

@ckirkendall I thought I fixed this? Cannot recall now