search

nervous-systems / serverless-cljs-plugin

Serverless plugin for Clojurescript deployment w/ cljs-lambda
The Unlicense
74 stars 10 forks source link

Let Serverless zip when using the lumo compiler #29

Closed arichiardi closed 6 years ago

arichiardi commented 6 years ago

This patch has one goal: use Serverless's packaging instead of our own for lumo. It has many advantages: include/exclude of files in the project root (previously missing), auto exclusion of devDependencies and others.

Moreover, a lot of code trimming happened because of course we don't need to use archiver anymore for zipping ourselves. As a side effect, there is no need to save the index.js somewhere else - it will always be generated and managed by the plugin.

Also, we need to exclude .lumo_cache and the lumo binary. The latter because of a defect in serverless that will be probably resolved at some point.

It is WIP because I am afraid I have missed something...I was removing tons of code and was in the back of my head saying: "It cannot be this much, I might be wrong".

So of course feedback welcome.

arichiardi commented 6 years ago

Should be good to go now.

arichiardi commented 6 years ago

Hey @moea, I am planning to present Lumo + serverless-cljs-plugin at the Conj 2017 (will you be there?): while this patch is not 100% necessary, it would be great to get there with this in place, if you have the time for reviewing it.

Btw thanks for your work, this plugin really helped my workflow a lot.

moea commented 6 years ago

Conceptually the changes are good, just made a few small comments.

Unfortunately I don't have plans to attend Conj, I've been to a couple of the previous ones (last year, and a couple of years before that), though.

arichiardi commented 6 years ago

Ok will address the comments, you will be here somehow anyways :smile:

Btw the next big thing I want to address is fail on WARNING, maybe after (or during) the Conj.

arichiardi commented 6 years ago

So if you think this other PR is ok and feel like merging, tomorrow I can rebase the other on top of this as well

arichiardi commented 6 years ago

Ok rebased this against master and it is now ready to go! :smile:

arichiardi commented 6 years ago

Ping :smile:

moea commented 6 years ago

@arichiardi I'm away at the moment, for work - I'll get this merged next week at the latest.

arichiardi commented 6 years ago

Thanks a lot for the prompt answer and sorry for being persistent :smile:

arichiardi commented 6 years ago

Perfect thank you!