Misc improvements to lumo build

[arichiardi]

This patch adds various improvements to the lumo build, notably:

• handle archiver warning
• add some useful debug logging
• fully forward vector as params to archiver's directory() and file()
• handle custom.cljsCompiler option in serverless.yml

[arichiardi]

I don't know how to change it against wip/lumo...

[arichiardi]

Why remove? It is so so useful when you have problems, you can ask a user to execute to send the output of the "Executing:" command..don't you think? -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[moea]

@arichiardi That hasn't been my experience - it's not helpful enough to justify the clutter. The serverless plugin logs the parameters it's passing to the script - everything else that's being logged could just as well be obtained by asking for the config file, or asking for a directory listing.

[arichiardi]

Ok, I can do that but I feel you really close for future kinds of compilers. And then you need to push a major version for the change? What is the advantage of a boolean? -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[arichiardi]

I can use camel case -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[moea]

If you prefer that, use camel case.

[arichiardi]

I think it makes more sense. Will change it. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[arichiardi]

Ok will remove the commit. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[arichiardi]

Ok addressed all the change requests and added some doc to the README

[moea]

Thanks - why is 1.7.0+ required, just so I know?

[arichiardi]

Because there is was a breaking change from lumo.core/command-line-args to cljs.core.

We could actually support both namespaces in our code but 1.7.0 will be broken unless we use an unmangled get on global.

https://github.com/anmonteiro/lumo/pull/237

[moea]

@arichiardi Why are we using *command-line-args* if the -main function receives the args as a sequence? With older versions of lumo, can you verify that receiving the arg vector still works? I would very much like to remove the version restriction.

[arichiardi]

The reason is node sends all the args, even the ones passed to lumo itself and we don't want those.

Sure I can tweak that.

[moea]

Yeah, let's work around it.

[moea]

@arichiardi Regarding the fix, is command-line-args empty, or unbound in older versions of lumo?

[arichiardi]

Premise: the above works for the three versions regardless, so seq does the right thing even when unbound.

In 1.6.0 we have only bound lumo.core, in 1.7.0 bound only cljs.core. In the bugged version, the lumo.core JS mangled object is filled but not bound in cljs, where cljs.core is but will always be nil.

[arichiardi]

Fix https://github.com/anmonteiro/lumo/pull/237/commits/fcba19a61203f9a5f3483195a39f0ecac6feadfb

[arichiardi]

Btw I have just noticed there that I don't need seq because it is already done in lumo.

[moea]

Presumably you can use the unmangled syntax to refer to the lumo.core var - lumo.core/*command-line-args*?

[arichiardi]

@moea not that would not work in 1.7.0. That is why I used the mangled version :wink:

[moea]

If lumo.core is required, why would it not work?

[arichiardi]

Good point! Maybe it is not required anymore? I have not investigated the why in depth, a bit in a hurry today.

[moea]

I mean if you just add (:require [lumo.core]) to the module, I don't see how it cannot work.

[arichiardi]

No I don't think it can work because the defonce is missing and therefore it is not in the compiler state.

However the global JS object is filled up at runtime so we can query it.

[moea]

If the namespace is required, you will get a compiler warning about an undefined var, and nil at runtime. Please make the change.

[arichiardi]

Will do, probably more verbose and uglier than what is now, but hey, you're the boss :smile:

[arichiardi]

Awesome, it seems like it is nice and working now :wink: