search

nervous-systems / serverless-cljs-plugin

Serverless plugin for Clojurescript deployment w/ cljs-lambda
The Unlicense
74 stars 10 forks source link

Use non-deprecated hook for package #9

Closed arichiardi closed 6 years ago

arichiardi commented 6 years ago

You can visualize the warning by doing:

SLS_DEBUG=* serverless package

moea commented 6 years ago

I've seen the message, but I don't know in what version of serverless the hook was deprecated - it'll be a breaking change for some percentage of users, if the rest of the module is compatible with that version. Do you know when it was deprecated?

arichiardi commented 6 years ago

Good point, I will find out.

arichiardi commented 6 years ago

It looks like this is the turning point: https://github.com/serverless/serverless/commit/d9637fc534e7c7d176e2e07b9b44a8a50561bebd, tag v1.20.2.

moea commented 6 years ago

I'm OK with living with the deprecation error for a while longer, I think.

arichiardi commented 6 years ago

Fair decision, closing this without deleting the branch if it's ok.