search

nerzhul / ncsms-android

repository for the ncsms on Android
95 stars 38 forks source link

Info: Fork of ncsms #230

Open PhieF opened 4 years ago

PhieF commented 4 years ago

Hi,

with the /e/ team we've forked ncsms both the app and the cloud app to suit our needs One feature that might interest you is the send sms from web ui, as well as filter conversation and start a conversation with a contact

you can find our code here: https://gitlab.e.foundation/e/apps/ncsms-android https://gitlab.e.foundation/e/apps/ncsmsgo/ https://gitlab.e.foundation/e/infra/selfhost/nextcloud-apps/esms

please contact me if you have any questions or need help to understand my messy commits, If you want the feature I can perhaps find some free time to make a pull request

Thanks a lot for your work !

nerzhul commented 4 years ago

why did you forked it instead of contributing ?

PhieF commented 4 years ago

I guess different reasons: We have specific needs, integration with our account manager, the modified import feature that only works with our sms app, as well as other things you might not find useful but we needed (features or design changes) I makes it easier to get it running more quickly. The fork is only for the /e/ operating system When I'll have time I will try to make specific merge request by features

e-alfred commented 4 years ago

@PhieF Can you contribute to the Android App and the Nextcloud app? Some of your changes might be of interest for Upstream and therefore our Nextcloud users as well especially the SMS sending feature.

Personally I like the idea of /e/, but contributing back and making Nextcloud better as a whole is surely a good way to archive the common goals of both projects.

PhieF commented 4 years ago

I totally agree with this, that's why I'd like to know what would interest you the most :) I will start with the send sms feature, and the filter + start conversation

e-alfred commented 4 years ago

@PhieF Aweseome, just let them roll in. :+1: I think any feature/bug fix that isn't completely /e/-specific would help us and the users. It would be great to push your changes to upstream regularly which would help everybody I think.

e-alfred commented 4 years ago

@PhieF anything new about pushing your changes to upstream? We would really like to make these features available to all of our Nextcloud users.

Thovi98 commented 4 years ago

@PhieF If you have any free time, I would love to see your features merged here !

azmeuk commented 2 years ago

I totally agree with this, that's why I'd like to know what would interest you the most :) I will start with the send sms feature, and the filter + start conversation

Gentle ping @PhieF. Is there any news on that front?