search

nesbox / TIC-80

TIC-80 is a fantasy computer for making, playing and sharing tiny games.
https://tic80.com
MIT License
4.88k stars 472 forks source link

Wren textri broken #1948

Open andraaspar opened 2 years ago

andraaspar commented 2 years ago

Hi,

I am getting:

-1, "TIC metaclass does not implement 
'textri(_,_,_,_,_,_,_,_,_,_,_,_,_,_)'."

A regression since TIC-80 0.90.1723. You can see it on: Carcassonne when you start a new game with 2 players. (New game, click 2 colors, click tick on bottom.)

Edit: regression info.

joshgoebel commented 1 year ago

I'm not sure I understand why this workaround was necessary?

https://github.com/nesbox/TIC-80/commit/1f28e3aa86edb52181c75290782a2770965aaf7a

nesbox commented 1 year ago

we accidentally removed textri() in wren, should be restored

nesbox commented 1 year ago

restored textri() in Wren 5a47a828d82d38ca666f0a0c20f1d947b471d921

technomancy commented 1 month ago

It looks like textri was also removed from Fennel and Lua:

>unknown:14:7 Compile error: unknown identifier: textri

(trace >>textri<<)

This breaks Spilljackers on 1.2.

andraaspar commented 1 month ago

I checked this using the game linked above, and textri is not working correctly in wren. You can see it when rotating tiles. It does not match the old version. It results in missing / broken texture.

On Sat, Jun 22, 2024, 08:38 Vadim Grigoruk @.***> wrote:

Reopened #1948 https://github.com/nesbox/TIC-80/issues/1948.

— Reply to this email directly, view it on GitHub https://github.com/nesbox/TIC-80/issues/1948#event-13249542503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2ZQPSLLRKFC4Q52U5RUK3ZIULXNAVCNFSM6AAAAABJKTVESCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI2DSNJUGI2TAMY . You are receiving this because you authored the thread.Message ID: @.***>