Issue

When using tab completion with load/save in a folder with a lot of files, or really anything that'd result in an output longer than CONSOLE_BUFFER_SCREEN, TIC-80 would crash. This is due to data->options of TabCompleteData overflowing and not being null-terminated.

Minimal repro:

Create 100 blank .tic files:

#!/bin/bash
mkdir repro && cd repro || exit 1
for i in {001..100}; do
  touch "test-$i.tic"
done

Start TIC-80 with the repro folder as its base: ./build/bin/tic80 --fs ~/repro

Type "load" and it'll likely crash. maybe not at first, but after a few tries at most, definitely.

Notes

This was a hell of a bug to track down, but also a fun one that made me learn lldb and ASAN. I have some other PRs coming soon about that.

Future improvements

I have a few suggestions for future improvements and PRs:

Upping CONSOLE_BUFFER_SCREEN (=760) to something higher, so more can be displayed, and suggestions will be cut off less at load/save
Having the suggestions sorted alphabetically, which they are currently not

String handling

This is a larger discussion, but it's worth considering either:

Migrating string operations in the codebase to strlcat which is safer and guarantees null-termination, or
Adopting a real string library, such as cstr from STC or SDS

Curious of your thoughts about the potential improvements I've listed in the two sections above.

Fixes https://github.com/nesbox/TIC-80/issues/2448.

nesbox / TIC-80

Fix tab-completion crash with load/save/etc. #2533

Issue

Minimal repro:

Notes

Future improvements

String handling