search

nesfit / fitcrack

A hashcat-based distributed password cracking system
https://fitcrack.fit.vutbr.cz/
Other
143 stars 30 forks source link

Improve mask-file validation #75

Closed alpatron closed 1 year ago

alpatron commented 1 year ago

Hi,

This PR should fix issue #74. I changed the regex that performs mask validation.

I changed the first section to ?[ludhHsab?1234]. Previously, this part would reject ?1, ?2, ?3, and ?4, which are valid variables, and it would reject ??, the escape sequence for the ? character.

I changed the second section to [ ->@-~] (any printable ASCII character and space with the exception of ?). Previously, this section would make the first section useless—?:, an invalid variable, would be incorrectly recognised as two static letters.

I tested the changes, and Webadmin now rejects the invalid mask file from issue #74.

davidbolvansky commented 1 year ago

Rebase please.

alpatron commented 1 year ago

Was fixed in 3ef5abd9dea11392a16e5f35f38cc294c8d38476, af0bb11f5656b7f8b01a91a6e65e1f5cf51fe475, and 6b3d92c07ff6edd765da6b32d9b3fe9da5e8b48a. So now this PR is not necessary.