search

nesfit / fitcrack

A hashcat-based distributed password cracking system
https://fitcrack.fit.vutbr.cz/
Other
143 stars 30 forks source link

Cannot create brute-force job with custom charsets; cannot use question-mark escape sequence in masks #80

Closed alpatron closed 1 year ago

alpatron commented 1 year ago

Hi,

Trying to create a job with a mask that contains a custom-charset variable ends with a "Wrong mask" error, and the mask input field on the Add Job page also shows that the mask is supposedly incorrect.

obrazek

Moreover, masks that contain the escape sequence for the question-mark sequence (??) are also rejected.

obrazek

It seems that the new regex introduced in the process of fixing issue #74 (3ef5abd9dea11392a16e5f35f38cc294c8d38476) is causing the issues; it now rejects too much.

It should be noted, that my proposed regex (PR #75), which was not accepted as the fix for issue #74, would not have these problems.

How to reproduce

  1. Go to Add Job and select the Brute-Force Mode
  2. Select a custom charset
  3. Try inputting the mask ?1 (or ?? to see the other bug described).
  4. The mask input field will show that the mask is invalid
  5. Try to create the job
  6. Job will not be created and a "Wrong mask" error will be shown
davidbolvansky commented 1 year ago

Please create a new pull request with fix.

OviOvocny commented 1 year ago

We fixed it (hopefully) in master right now. Try it out.

alpatron commented 1 year ago

@OviOvocny I can now create jobs with all the masks that were giving issues. All seems fixed. 👍