nespinoza / juliet

A versatile modelling tool for transiting and non-transiting (single and multiple) exoplanetary systems
MIT License
55 stars 30 forks source link

Adding Matern+SHO kernel; `fp`, `p`, `p1` and `p2` are planetary and instrumental parameters #85

Closed Jayshil closed 2 years ago

Jayshil commented 2 years ago

This pull request adds a new GP kernel: summation of Matern-3/2 and SHO kernel from celerite. As usual, the new kernel can be called by providing specific priors: GP_sigma_instrument, GP_rho_instrument, GP_S0_instrument, GP_Q_instrument, GP_omega0_instrument. --Jayshil

Jayshil commented 2 years ago

The recent commit makes the eclipse depth planetary and instrumental parameter. That means users now have to use fp_p1_instrument while providing priors on eclipse depth. Users can combine fp over multiple instruments (just like limb darkening coefficients) by fp_p1_instrument1_instrument2. The time correction factor, ac, is still a planetary parameter.

Jayshil commented 2 years ago

This PR will make the following changes: 1) Adding a new GP kernel: summation of Matern and SHO kernel 2) Making fp, p, p1 and p2 planetary and instrumental parameters. That is, to use any of these parameters the user needs to provide something like, fp_p1_instrument etc. (note that the planet number goes first, and then the instrument name(s)). Instruments can be shared for these parameters (i.e., fp_instrument1_instrument2 is possible). This can be used for multiple planets.