search

nesquena / dante

Turn any ruby code into a daemon.
MIT License
313 stars 17 forks source link

Major refactor #12

Open krainboltgreene opened 10 years ago

krainboltgreene commented 10 years ago

So this started off as me just implementing that logger change, but ended up as a major refactor. I didn't start off with this in mind but I think it's something that'll be good for anyone using dante, with the following being the most important:

  1. No more internal logging code.
  2. No more internal PID management
  3. No more erb or yaml requirements (Not sure why they're even required?)
  4. Smaller surface to test.
  5. Easier time inheriting the core class for custom daemon classes.

Some things still left to be done:

  1. Pid file management, probably with https://github.com/samullen/pidfile
  2. User/group management
  3. Some default tests, maybe
  4. Built in stop/start/restart commands?
Paxa commented 10 years ago

Looks good, I wish it would be merged

leucos commented 10 years ago

:+1:

bdandy commented 10 years ago

Yeah, looks nice!

bdandy commented 9 years ago

@nesquena, will you accept this pull request?

nesquena commented 9 years ago

I haven't looked at dante in a long while but sure I will merge this in, sorry it took so long. If anyone wants to help out as a contributor / maintainer for dante, I'd certainly appreciate the help.

krainboltgreene commented 9 years ago

I now manage hamstergem/hamster, I don't mind maintaining another gem.

nesquena commented 9 years ago

Great, I've added you as a collaborator for dante. Appreciate you stepping in.

mkonikowski commented 9 years ago

Is this project alive? Any updates on the status of this PR?

krainboltgreene commented 9 years ago

Semi-sortive? My initial goal was to revamp dante, but frankly with the advent of things like systemd it seems like dante really isn't needed.

There are better CLI frameworks (clamp, commander) and there are easier to use process management tools now (upstart, systemd, launchctl).

Frankly dante.gem is old.

On Fri, Jun 26, 2015 at 3:40 AM, Mateusz Konikowski < notifications@github.com> wrote:

Is this project alive? Any updates on the status of this PR?

— Reply to this email directly or view it on GitHub https://github.com/nesquena/dante/pull/12#issuecomment-115576776.

Kurtis Rainbolt-Greene, Hacker Software Developer 1631 8th St. New Orleans, LA 70115