nesquena / gitdocs

Open-source Dropbox using Ruby and Git
https://blog.codepath.com/2011/11/30/collaborate-and-track-tasks-with-ease-using-gitdocs/
MIT License
1.14k stars 48 forks source link

Convert to use the Celluloid framework #104

Closed acant closed 9 years ago

acant commented 9 years ago

This is an initial straight forward conversion, and does not change much about how the daemon executes. Stills cleans up some of the code, I believe. There will be more changes to how things run, that I think can be implemented more easily with Celluloid.

acant commented 9 years ago

The test suite passes locally, but I am still seeing some errors in Celluloid during termination which could be contributing to the Travis failures. Travis has also upgraded to PhantomJS v2, but I have been using v1.9.0 locally. This could also be contributing to the failures. I will continue investigating and learning more about both PhantomJS and Celluloid.

acant commented 9 years ago

Given the number of changes that this has turned into, and the Travis failure I am going to close this PR, and break it into some smaller onces. (e.g., cleanup, gem upgrades, notiffany conversion, celluloid stuff) Hopefully this will allow some changes to get merged faster, and clarify what is happening with the Travis failures.