Celluloid convertion attempt number 3

nesquena / gitdocs

Open-source Dropbox using Ruby and Git

https://blog.codepath.com/2011/11/30/collaborate-and-track-tasks-with-ease-using-gitdocs/

MIT License

1.14k stars 48 forks source link

Celluloid convertion attempt number 3 #117

Closed acant closed 8 years ago

acant commented 8 years ago

Opening the PR, just in case the works out of the box. The Celluloid conversion commit has gotten much smaller than before, because the various supporting changes have already been made. The tests all pass locally, but I expect there to be failures on TravisCI.

acant commented 8 years ago

(And I may still split out the Initializer.foreground= and Notiffany commits into a separate PR, just to get them commit. For tonight I just want to see what TravisCI does with this code.)

nesquena commented 8 years ago

This is great thanks! Any chance you can help get Travis passing again? :(

acant commented 8 years ago

Hmm, I am pretty sure everything works, but it still seems to have a problem with the edit scenario. Although there was at least 1 green ruby version, which makes me suspect a timing issue. I will play with this some more and see if I can get it passing consistently.