search

nesquena / gitdocs

Open-source Dropbox using Ruby and Git
https://blog.codepath.com/2011/11/30/collaborate-and-track-tasks-with-ease-using-gitdocs/
MIT License
1.14k stars 48 forks source link

Adding integration test for the UI #89

Closed acant closed 10 years ago

acant commented 10 years ago

This is not ready yet, but I am opening the PR because I want to see if the test will work on Travis. I hope to have integration tests for both the browsing and settings components of the web UI.

acant commented 10 years ago

hmm, trying to add more within blocks and see if improves the failures in TravisCI. I suspect they are timing related.

acant commented 10 years ago

another try: increasing the Capybara wait_time to see if that helps on TravisCI

acant commented 10 years ago

that helped a little, I think, but still a failure in the Revision viewing test. I'll keep looking into it.

acant commented 10 years ago

So, I have a compromise solution for the TravisCI tests, where I just disable the tests that are failing. But they still run and pass locally.

@nesquena do you have some time to install PhantomJS and try running the tests? If they work for someone else, then I think disabling on Travis is the way to go for now. I will leave FIXME markers as a reminder, and hopefully be able to get them working everywhere in the future.

I'll clean up the commits tomorrow and get this ready for merging.

acant commented 10 years ago

@nesquena Cleaned up and ready for merging.

nesquena commented 10 years ago

Great, stuff, reasonable compromise as the tests seem to run for me locally.

acant commented 10 years ago

Thanks for checking, hopefully this will run on CI in the future.