search

nesquena / rabl

General ruby templating with json, bson, xml, plist and msgpack support
http://blog.codepath.com/2011/06/27/building-a-platform-api-on-rails/
MIT License
3.64k stars 334 forks source link

Fix problem of usage rabl 0.13.0 with Rails 5 and active cache #679

Closed le0pard closed 8 years ago

nesquena commented 8 years ago

Thanks!

le0pard commented 8 years ago

@nesquena thanks, but looks like I need fix something, if it was reverted, isn't it?

nesquena commented 8 years ago

Did you mean to just remove all that code in the digestor?

le0pard commented 8 years ago

@nesquena I removed it, because Rails 5 Digestor doesn't have an initializer and the 3rd parameter is actually the dependencies and not the options ( https://github.com/rails/rails/blob/master/actionview/lib/action_view/digestor.rb#L21 ). We're already calling Digestor.digest with the same signature as the built-in digest, so we can just use that. After this changes I checked it on staging server of my app and cache in rabl continue working (output by redis monitor):

1476651478.597309 [0 127.0.0.1:9318] "mget" "cache:rabl/inboxes/1-20160201121619264569-86-0//hash/43ff2ca40b70ad2989bc2a776124e03e" "cache:rabl/inboxes/3-20160122094313966306-12-0//hash/43ff2ca40b70ad2989bc2a776124e03e" "cache:rabl/inboxes/74-20160202133857021443-0-0//hash/43ff2ca40b70ad2989bc2a776124e03e" ""
1476651478.609248 [0 127.0.0.1:9318] "mget" "cache:rabl/inboxes/2-20160121173326340571-558-0//hash/43ff2ca40b70ad2989bc2a776124e03e" ""
1476651478.633126 [0 127.0.0.1:9318] "mget" "cache:rabl/inboxes/4-20161013151423574157-104-0//hash/43ff2ca40b70ad2989bc2a776124e03e" "cache:rabl/inboxes/5-20161013151423574157-165-0//hash/43ff2ca40b70ad2989bc2a776124e03e" "cache:rabl/inboxes/39-20161013151423574157-0-0//hash/43ff2ca40b70ad2989bc2a776124e03e" "cache:rabl/inboxes/68-20161013151423574157-0-0//hash/43ff2ca40b70ad2989bc2a776124e03e" ""
nesquena commented 8 years ago

Thanks, added back here then https://github.com/nesquena/rabl/commit/f6d967294105a7d486d541e5b52cc46388f9d75b

le0pard commented 8 years ago

@nesquena thank you too.

jhawthorn commented 8 years ago

@nesquena can we get a gem version cut for this? The existing versions do not work on rails 5.

nesquena commented 8 years ago

@jhawthorn Yep pushed 0.13.1 just now. Thanks for the reminder