nesquena / rabl

General ruby templating with json, bson, xml, plist and msgpack support
http://blog.codepath.com/2011/06/27/building-a-platform-api-on-rails/
MIT License
3.64k stars 334 forks source link

Make tests run on Ruby 2.5 #709

Closed droberts-sea closed 6 years ago

droberts-sea commented 6 years ago

There was an obsolete flag being passed to the test command.

I've removed the flag only for versions of ruby >= 1.9. That's when this flag became unnecessary, and it was removed with ruby 2.5.

See Ruby release notes for 2.5 at: https://github.com/ruby/ruby/blob/v2_5_0/NEWS#stdlib-compatibility-issues-excluding-feature-bug-fixes

The short suite of tests passes on 2.5 with this change.

I was not able to get the full suite of integration tests to run, with either Ruby 2.4 or 2.5. I did follow all the steps in the Rakefile (rake test:clean; rake test:setup; rake test:full) Is this still something that's used for this project?

nesquena commented 6 years ago

Thanks!