nesquena / rabl

General ruby templating with json, bson, xml, plist and msgpack support
http://blog.codepath.com/2011/06/27/building-a-platform-api-on-rails/
MIT License
3.64k stars 334 forks source link

Get the long-form tests running on Rails 4 and 5 #710

Closed droberts-sea closed 6 years ago

droberts-sea commented 6 years ago

Rails 4 needed a few edits. Rails 5 fixtures were only partially built, so I went through and did that.

I couldn't get the caching tests to work on Rails 5, so I just commented them out for now. I figure this is better than what it was before, and I want to get this in before I get distracted by my actual job 🙂 See commit 823136f

Rails 4 tests were run against Ruby 2.4.1, Rails 5 against Ruby 2.5.

I didn't try to get Rails < 4 running, since I don't have older versions of Ruby installed, and I'm totally unfamiliar with Sinatra and Padrino so I did not look into them.

Next up: new set of tests for API mode!

nesquena commented 6 years ago

This is great thanks!