Make Rails 6 compatible

nesquena / rabl

General ruby templating with json, bson, xml, plist and msgpack support

http://blog.codepath.com/2011/06/27/building-a-platform-api-on-rails/

MIT License

3.64k stars 334 forks source link

Make Rails 6 compatible #723

Closed jpawlyn closed 5 years ago

jpawlyn commented 5 years ago

And additionally remove the following deprecation message (caused by https://github.com/rails/rails/commit/28f88e0074)

ActiveSupport::DeprecationException: DEPRECATION WARNING: Single arity
template handlers are deprecated.  Template handlers must now accept two
parameters, the view object and the source for the view object.
Change:
  >> Class#call(template)
To:
  >> Class#call(template, source)

jpawlyn commented 5 years ago

@nesquena Hi. If there's work needed on this PR please let me know. I haven't added a Rails 6 API only app. Would that be useful?

nimashariatian commented 5 years ago

Hi guys, can this be merged? we'd really appreciate it

nesquena commented 5 years ago

Merged, thanks will put out a release, can you all confirm this works off master?

nimashariatian commented 5 years ago

@nesquena Thank you! we're running this on our CI, I'll report back shortly

ojab commented 5 years ago

CI passed just fine here with rabl master & rails-6.

jpawlyn commented 5 years ago

@nesquena Thanks, works for us as well.

nimashariatian commented 5 years ago

@nesquena just wanted to echo our CI passed as well. thank you!

ojab commented 5 years ago

JFYI: our specs with rails-5 & rabl master also passed (it's also gentle ping to make a release pretty please)

nesquena commented 5 years ago

Pushed a new version https://rubygems.org/gems/rabl/versions/0.14.2, thanks all! Especially @jpawlyn