search

nessnaj / alfen_eve_modbus_tcp

Python module for reading Alfen Eve (Single) Pro-Line 3 Phase car charger
MIT License
1 stars 0 forks source link

Fix pymodbus dependency #1

Closed marcelstoer closed 5 months ago

marcelstoer commented 5 months ago

pymodbus 3.5 (currently at 3.6.8) introduce enums for, amongst others, endian values. To be consistent, we need to bump its requires value.

Source: https://github.com/pymodbus-dev/pymodbus/pull/1743

N.B. solaredge_modbus also fixed this last fall.

nessnaj commented 5 months ago

Hi Marcel, thank you for notifying. I was aware of the changes in pymodbus and was even surprised of your pull request as I had already applied those changes myself... However, I have never committed them to the Github repository (they are still in a local reporsitory) and therefore were not visible to others. My bad :-(

As the updates entail a little bit more than your proposal (version will bump from 0.0.7 to 0.0.11), I will make sure to commit my changes made in the past. I hope to do that tonight.

nessnaj commented 5 months ago

Brought Github source up to date and included latest changes (basically including your changes), so upgraded to version 0.0.12. Apologies for not having this done before :-(

Thank you again for notifying.