search

nest-modules / ioredis

:see_no_evil: :hear_no_evil: :speak_no_evil: A ioredis module for Nest framework (node.js)
MIT License
145 stars 31 forks source link

Compatibility with @nestjs/common >= 9.0.0 #258

Closed stouch closed 11 months ago

stouch commented 2 years ago

When using @nestjs/common >= 9.0.0 with npm 8, cannot install this lib without forcing --legacy-peer-deps

stouch commented 2 years ago

For v9 compatibility, we'll have to use another config format to fit with @nestjs/microservices and ioredis lib :

See https://github.com/nestjs/terminus/issues/1288#issuecomment-1189444864

url seems not allowed anymore

Should we work on a PR @juandav or maybe you going to work on it soon ?

stouch commented 2 years ago

up 😇

Also seen that NestJS redis docs have changed a lot compared to the previous one (https://docs.nestjs.com/microservices/redis), I don't known how much this gonna affect this repo

jonparkdev commented 1 year ago

bump

atassis commented 1 year ago

@juandav you have added support for the 9th version of nestjs, but didn't update the package in the npm.

vadimoarturo commented 1 year ago

up

srkimir commented 1 year ago

+1

pastean commented 1 year ago

is it safe to use by ignoring deps?

dzcpy commented 1 year ago

Any updates? @jonparkdev @dantehemerson @cdiaz Please publish the package to npm... Thanks!

srkimir commented 1 year ago

Can somebody please look into this

srkimir commented 1 year ago

Get rid of this package finally completely in favour of https://github.com/liaoliaots/nestjs-redis which supports nest >=9.0.0 migration is quick and easy

piyush-kacha commented 1 year ago

Can somebody please look into this

Code is already updated in master branch just somebody need to update in NPM.

vadimoarturo commented 1 year ago

Get rid of this package finally completely in favour of https://github.com/liaoliaots/nestjs-redis which supports nest >=9.0.0 migration is quick and easy

Will there be an update or can this one be used?

juandav commented 11 months ago

The library has already been updated to the latest version.