nest-modules / mailer

📨 A mailer module for Nest framework (node.js)
https://nest-modules.github.io/mailer/
MIT License
837 stars 176 forks source link

Old css-inline dependency missing, but still required #1119

Closed xsvetli1 closed 6 months ago

xsvetli1 commented 7 months ago

Describe the bug I did some investigation and it seems after your commit 4f79d29, any app using handlebars will crash before even starts (same as mine is at the moment). The issue is the error message:

Error: Cannot find module 'css-inline'
Require stack:
- /app/backend/node_modules/@nestjs-modules/mailer/dist/adapters/handlebars.adapter.js

Basically, your most up-to-date version of the @nestjs-modules/mailer is after commit 4f79d29 missing dependency css-inline which was replaced by @css-inline/css-inline. However, it is not the same package! And in the handlebars.adapter.js, you are still trying to import the old css-inline.

I was able to fix it by installing css-inline to my app as dependency, but I believe your goal was to get rid of this old dependency, so please fix the import in handlebars.adapter.js. It may be also used somewhere else, so some deeper investigation, of some other old css-inline imports which were forgotten would be very helpful.

To Reproduce Use the handlebar with the mailer and try to run your app.

Expected behavior App using mailer with handlebar runs successfuly.

phxgg commented 6 months ago

Same issue with EJS.

akrio714 commented 6 months ago

Same issue

yjradeh commented 6 months ago

same

michal-worwag commented 6 months ago

Same here

lostation commented 6 months ago

same here with EjsAdapter ;)

daniloras commented 6 months ago

same here ----- HAVE PROBLEM

juandav commented 6 months ago

I have corrected the dist that was uploaded to npm, now you should not have this problem

wagnersillva commented 6 months ago

same here... Any solution? I'm using docker to deploy my nestjs application.

basz commented 6 months ago

It was fixed in latest version. Otherwise add css-inline as dependency