nest-modules / mailer

📨 A mailer module for Nest framework (node.js)
https://nest-modules.github.io/mailer/
MIT License
837 stars 176 forks source link

incompatible with nestjs v8 #654

Closed flamewow closed 9 months ago

flamewow commented 3 years ago

` $ npm i @nestjs-modules/mailer

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: test@0.0.1 npm ERR! Found: @nestjs/common@8.0.0 npm ERR! node_modules/@nestjs/common npm ERR! @nestjs/common@"^8.0.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @nestjs/common@"^7.0.9" from @nestjs-modules/mailer@1.6.0 npm ERR! node_modules/@nestjs-modules/mailer npm ERR! @nestjs-modules/mailer@"*" from the root project `

nelsonBlack commented 3 years ago

npm install --save @nestjs-modules/mailer nodemailer --legacy-peer-deps

vschst commented 3 years ago

https://github.com/nest-modules/mailer/pull/685/commits/08e61f637e022111fcbb9c0239c1b3bfab1549c6

joeyaurel commented 3 years ago

@nelsonBlack will there be a release for the changes that @victor192 mentioned?

omsharp commented 3 years ago

Can you, please, look into @victor192's PR? I desperately need this update.

faan11 commented 2 years ago

are there any updates about this?

SergioSuarezDev commented 2 years ago

+1 plz update

MarkPieszak commented 2 years ago

Hey everyone!

So this is a peerDependencies issue, and it looks like the code here in Github has been updated to include the necessary change, but I believe it hasn't been PUBLISHED to NPM yet. cc @juandav @cdiaz

That would fix it though :)

For those curious, it's these lines here that have to keep being updated for each new version (and published to npm). This is something new to npm, and it can be fixed either on a package-level, or via npm i --legacy-peer-deps (as mentioned elsewhere).

SergioSuarezDev commented 2 years ago

Hey everyone!

So this is a peerDependencies issue, and it looks like the code here in Github has been updated to include the necessary change, but I believe it hasn't been PUBLISHED to NPM yet. cc @juandav @cdiaz

That would fix it though :)

For those curious, it's these lines here that have to keep being updated for each new version (and published to npm). This is something new to npm, and it can be fixed either on a package-level, or via npm i --legacy-peer-deps (as mentioned elsewhere).

Thanks @MarkPieszak ! from nest core team :)

faan11 commented 2 years ago

Let's wait for the new release🤞

antoineviscardi commented 2 years ago

Do you guys have an ETA on when a patch will be released to NPM?

antoineviscardi commented 2 years ago

712