search

nest / nest-extension-module

Custom extension module for NEST
0 stars 12 forks source link

Revised module suitable for new NESTExtensionModule interface #26

Closed heplesser closed 6 months ago

heplesser commented 9 months ago

This is the first example (in draft state) of the new NESTExtensionInterface and ModuleManager approach to handling modules.

heplesser commented 9 months ago

Even while the example module still needs a lot of polishing, this one should be reviewed and merged soon so we have one that works with the new NEST mechanism. Then we also need to think about versioning these modules, we need releases that fit the NEST releases.

terhorstd commented 8 months ago

Actions need to be re-run when nest/nest-simulator#3103 is merged.

pnbabu commented 7 months ago

@heplesser ping!

heplesser commented 6 months ago

@terhorstd @pnbabu I have now addressed your comments, I hope to your content.

heplesser commented 6 months ago

It looks good to me overall. I am fine with merging this after fixing the failing build on macOS.

I have now hiked the Python version to 3.12, so building should work again on macOS.

heplesser commented 6 months ago

But now the Linux build failed with what looks like a problem not related to our code. Strangely, I do not find a re-run button for actions in this repo. Let's see how it goes with the macOS build.

pnbabu commented 6 months ago

But now the Linux build failed with what looks like a problem not related to our code. Strangely, I do not find a re-run button for actions in this repo. Let's see how it goes with the macOS build.

Perhaps it's the access issue? I could see the button and the job is running again now.