nest / nest-simulator

The NEST simulator
http://www.nest-simulator.org
GNU General Public License v2.0
536 stars 364 forks source link

Correct numerics of gif_cond_* neurons #1565

Open heplesser opened 4 years ago

heplesser commented 4 years ago

While analysing #1097, we discovered that the numerics of the gif_cond_ neuron have slight weakness: The spike triggered current is evolved outside the ODE solver, so a constant stc value is applied during all sub-steps of a NEST time step. The stc should be updated inside the rhs function, to have exact values at each substep.

clinssen commented 4 years ago

For more details, see #1582

github-actions[bot] commented 3 years ago

Issue automatically marked stale!

heplesser commented 2 years ago

@clinssen @pnbabu Ping!

clinssen commented 1 year ago

Do we prefer the precise analytic solution to be computed inside the GSL solver inner loop? This would provide numerical precision at the expense of some more exp() calls. We can also numerically approximate this decay inside the GSL loop and replace it with precise values at the end of every timestep. In the first case, we will need to dynamically allocate the ODE state vector, as the model supports an arbitrary number of STC and SFA time constants, and these will all have to go into the state vector.

heplesser commented 1 year ago

I would argue for precision at the expense of exp() calls.

github-actions[bot] commented 1 year ago

Issue automatically marked stale!