search

nest / nest-simulator

The NEST simulator
http://www.nest-simulator.org
GNU General Public License v2.0
544 stars 370 forks source link

`iaf_tum_2000` fails in `test_refractory.py` due to hijacking the offset field #2912

Open nicolossus opened 1 year ago

nicolossus commented 1 year ago

In the upcoming iaf_tum_2000 model, we hijack the offset field intended to be used by precise spiking models. With the current implementation, the event from any model with is_off_grid set to true will be treated as a precise spiking event. This means that the spikes from iaf_tum_2000 will be recorded as precise spike times, even though the iaf_tum_2000 is not a precise spiking model.

That spikes are recorded as if they were precise for iaf_tum_2000 have the unfortunate consequence of breaking the logic of the test in test_refractory.py. The iaf_tum_2000 model is therefore added to the ignore_model list.

This issue will be resolved when the offset field is reimplemented to just be a generic data field. iaf_tum_2000 should then be removed from the ignore_model list.

github-actions[bot] commented 1 year ago

Issue automatically marked stale!