This PR fixes issue #64 which relates to installer unique ID. Might be useful to read the comments in the issue page.
closes #64
Instructions for Reviewer(s)
Review
Hey @sqr00t could you please double check things still look good after the changes in asf_core_data/pipeline/mcs/process/process_historical_mcs_installers.py? Many thanks!
Setup
In case you want/need to run anything:
clone this repo: git clone git@github.com:nestauk/asf_core_data.git
checkout to the correct branch: git checkout 64_accuracy_installers_unique_id
Run make install;
Run direnv allow;
Activate the conda enviroment: conda activate asf_core_data;
Set your API credentials as environment variable, i.e run export COMPANIES_HOUSE_API_KEY="ADD_YOUR_API_KEY_HERE" in the command line and replace ADD_YOUR_API_KEY_HERE with your API key credentials.
Changes in this PR didn't add any code, only commented out some code. I double checked with Chris and he agrees with the changes. Additionally code runs smoothly, so will now merge to dev.
Description
This PR fixes issue #64 which relates to installer unique ID. Might be useful to read the comments in the issue page.
closes #64
Instructions for Reviewer(s)
Review
Hey @sqr00t could you please double check things still look good after the changes in
asf_core_data/pipeline/mcs/process/process_historical_mcs_installers.py
? Many thanks!Setup
In case you want/need to run anything:
git clone git@github.com:nestauk/asf_core_data.git
git checkout 64_accuracy_installers_unique_id
make install
;direnv allow
;conda activate asf_core_data
;export COMPANIES_HOUSE_API_KEY="ADD_YOUR_API_KEY_HERE"
in the command line and replaceADD_YOUR_API_KEY_HERE
with your API key credentials.