nestauk / asf_core_data

Processing core datasets used in Nesta's A Sustainable Future mission
MIT License
3 stars 1 forks source link

Dealing with false positives in unique ID #79

Closed sofiapinto closed 1 year ago

sofiapinto commented 1 year ago

Description

This PR fixes issue #64 which relates to installer unique ID. Might be useful to read the comments in the issue page.

closes #64

Instructions for Reviewer(s)

Review

Hey @sqr00t could you please double check things still look good after the changes in asf_core_data/pipeline/mcs/process/process_historical_mcs_installers.py? Many thanks!

Setup

In case you want/need to run anything:


sofiapinto commented 1 year ago

Changes in this PR didn't add any code, only commented out some code. I double checked with Chris and he agrees with the changes. Additionally code runs smoothly, so will now merge to dev.