Removes a threshold from the config and from find_job_quality.py. Adds a unit test to make it easier to check whether any changes to find_job_quality.py break it.
Fixes #76
Instructions for Reviewer
In order to test the code in this PR you need to ...
Run python dap_job_quality/pipeline/find_job_quality.py (this runs the script in test mode, on a sample of just 10 adverts)
Run pytest dap_job_quality/tests/test_extract_job_quality.py (this runs the new unit test)
Checklist:
[x] I have refactored my code out from notebooks/
[x] I have checked the code runs
[x] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have merged any new changes from dev
[x] I have documented the code
[x] Major functions have docstrings
[x] Appropriate information has been added to READMEs
Description
Removes a threshold from the config and from
find_job_quality.py. Adds a unit test to make it easier to check whether any changes tofind_job_quality.pybreak it.Fixes #76
Instructions for Reviewer
In order to test the code in this PR you need to ...
python dap_job_quality/pipeline/find_job_quality.py(this runs the script in test mode, on a sample of just 10 adverts)pytest dap_job_quality/tests/test_extract_job_quality.py(this runs the new unit test)Checklist:
notebooks/pre-commitand addressed any issues not automatically fixeddevREADMEs