search

nestauk / daps_utils

Tools for setting up and running pipelines in a Data Analytics and Production System (DAPS).
0 stars 1 forks source link

[63] Update docker client #64

Closed dtprogammer closed 3 years ago

dtprogammer commented 3 years ago

Update docker client to remove volumes and use existing AWS credentials using environment vars, remove intermediate containers to reduce image size for Docker in Docker config, Enable auto-remove when containers process exits.

jaklinger commented 3 years ago

After merging in changes from #67 I see an error from the adding of kwargs rm=True (https://travis-ci.com/github/nestauk/daps_utils/jobs/504272814#L3104) because some containers are both implicitly and explicitly removed. I've committed a change which fixes this:

https://github.com/nestauk/daps_utils/pull/64/files#diff-5802e78a43e17d038c80e743f5e58f0e18ab32ab6b6239b06b3e4c563be448daR193-R197

jaklinger commented 3 years ago

(@bishax just requesting your review since I've also contributed to the PR and so probably blind to my own mistakes)

dtprogammer commented 3 years ago

Since the changes are approved, I am merging the commit for use in ojd_daps.