Closed lizgzil closed 12 months ago
You could change the action to only run on pull request, and make any changes to the dev branch required to be pushed through a pull request which will fix the double trigger of the unit test as sadly you can't do push or pull
Hi @Aiden-RC - after a discussion with the team we decided to remove the checks triggering on a pull request, and added some info about this to the readme. Thanks so much for helping with this!!
Hi @Aiden-RC - after a discussion with the team we decided to remove the checks triggering on a pull request, and added some info about this to the readme. Thanks so much for helping with this!!
Yeah thats a better way of doing it than double triggering actions and it's all good :)
@Aiden-RC 's changes from https://github.com/nestauk/ojd_daps_skills/pull/183 to allow the package to run on Windows
Thanks for contributing to Nesta's Skills Extractor Library 🙏!
If you have suggested changes to code anywhere outside of the ExtractSkills class, please consult the checklist below.
Checklist ✔️🐍:
notebooks/
pre-commit
and addressed any issues not automatically fixeddev
README
soutput/reports/
If you have suggested changes to documentation (and/or the ExtractSkills class), please ALSO consult the checklist below.
Documentation Checklist ✔️📚:
make html
indocs
docs/build/*.html
files locally to ensure they have formatted correctlydocs/build/*.html
files