nestauk / old_nesta_daps

[archived]
MIT License
18 stars 5 forks source link

[326 precursor] File/variable renaming factored out from 326_nih #328

Closed jaklinger closed 4 years ago

jaklinger commented 4 years ago

Refers to #326

Refactors the name health_data to nih across the system.

The only addition on top of this are 3 dummy routines which will be filled in child PRs.

jaklinger commented 4 years ago

I see the following 21 references to health_data:

Thanks, fixed.

jaklinger commented 4 years ago

What's the reason for the apparent duplication of nih_root_task, nih_dedupe_task , nih_process_tasks (and accompanying tests)?

Apologies for the mess: these are placeholders which will be filled in in the subsequent PRs in this chain.

jaklinger commented 4 years ago

@bishax Thanks for the review. I've factored out the utils stuff, so there's nothing particularly controversial left in here now. I was going to factor out the orms as well, but seeing as you've already reviewed them I'll keep them in. I'll merge in the morning, if all tests should pass.

There are two small PRs coming your way after this: