search

nestdotland / nest.land

🦕 The Nest Website
https://nest.land
MIT License
371 stars 19 forks source link

tweak SEO of package detail page #272

Closed g-plane closed 3 years ago

g-plane commented 3 years ago

When package information fetched at package detail page, title and description of the page will be updated. Once leave the page, title and description will be restored.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nestdotland/nest-land/csdu9vsgl
✅ Preview: https://nest-land-git-fork-g-plane-seo-tweak.nestdotland.vercel.app

g-plane commented 3 years ago

No, because I'm not able to test it before the preview deployment.

g-plane commented 3 years ago

Oh, it doesn't work. Maybe the reason is that the package info is fetched at runtime, and the soical services can't wait for it.

t8 commented 3 years ago

Yes, I think that is the issue. @martonlederer has tried to get around this, but if I remember correctly, we came to the conclusion that SSR would be necessary for this capability to exist on the site.

@g-plane, would you mind removing the dynamic Twitter pieces (and whatever else is affected)? I'd still like to merge the pieces that do work (ex: the title changing).

martonlederer commented 3 years ago

Yeah, we will probably do this SSR in 1.0