nesterapp / react-native-streetview

React Native Google's Panorama/StreetView component for iOS and Android.
MIT License
99 stars 52 forks source link

Callback mismatch between iOS and Android #28

Closed taknuti closed 4 years ago

taknuti commented 5 years ago

We use the 'onError' callback to render a map if, for whatever reason, street view is not loading. This week we discovered this was not working on Android. After diving a bit in the repo I found that on Android the callback is called 'onStreetViewError'.

This is a bit confusing and not well documented. I would suggest making the names the same. If not, a bit of documentation to explain this might be welcome.

amitpdev commented 4 years ago

Fixed by #36