Closed welljsjs closed 5 years ago
Hi @welljsjs. Currently I have no free time to maintain the pod by myself. I really appreciate your work and will review the PR and hope to merge it soon
Having a little issue at the moment because pjsip ≥ 2.6 expects to be built with OpenSSL-1.1.x. That's at least what their docs say.
This PR does not include OpenSSL-1.1.x. I don't know whether this is an issue after upgrading to pjsip 2.8. If s.o. reports an issue regarding this, we'll probably have to revert this PR and fall back to 2.6 again due to compatibility issues.
I don't know how pjsip ≥ 2.6 behaves with OpenSSL-1.0.x, although I'm getting no errors when building.
Unfortunately, the OpenSSL-for-iPhone repo does not seem to support OpenSSL-1.1.x versions according to their build script:
Note: This script does not yet work with OpenSSL 1.1.0
Also, I'm now switching to OpenSSL-Universal , which is a requirement for building for macOS in order to create a multi-platform pod and it seems to support OpenSSL 1.1.x. I'll keep this comment up-to-date.
I finally managed to build pjsip 2.8 with OpenSSL 1.1.1b (the latest official LTS openssl version) by using a custom build script. The code is heavily borrowed from OpenSSL-Apple. With that script, it's easy to build OpenSSL for macOS, iOS, watchOS and tvOS. I adapted it to meet our requirements. Now it's time to build opus for iOS and macOS.
Just wondering: Does this repository still want to support i386 architectures? Since iOS 11, Apple does not support 32-bit apps anymore, meaning that any 32-bit apps get rejected when being submitted to the AppStore. Also, do we want to support devices like iPhone 5 (≤ iPhone 5) (armv7) (iPhone 5s excluded)? I'd suggest moving to 64-bit only (≥ iOS 7), this simplifies the process of building a lot.
The macOS 10.14 SDK no longer contains support for compiling 32-bit applications. If developers need to compile for i386, Xcode 9.4 or earlier is required. (39858111)
Upgraded sources (#61)
I think one could consider using
VideoToolbox
framework instead ofH.264
, which will improve hardware acceleration (also means less third-party dependencies).Additionally, I also think that it's completely possible to support iOS and macOS with a single pod. Just look at OpenSSL-Universal and how they deal with that. I'll try to build something similar for pjsip within the next days or weeks.
@chebur (sorry to wake you up), but is this repo still maintained/do PRs get reviewed and accepted? Otherwise, I'd consider publishing my own version of this.