search

nesterone / sf-eng-init-bazzika

Software Engineer Initiation for Bazzika
MIT License
3 stars 4 forks source link

Updates of Content and Pre-Commit Hooks #452

Closed nesterone closed 8 years ago

nesterone commented 8 years ago

Pull Request

  1. Run npm install
  2. Run npm run lint
  3. Fix all issues with code
  4. Commit

After that poin, you won't be able to commit unlinted code

DeuceX commented 8 years ago

Thanks, @nesterone . But it doesn't work for me :(

I merged pull request, and pull'd it from GitHub. When I tried npm install I got some warnings and install didn't work. I tried to delete "node_modules" folder and after this that warnings went away.

Then I tried to write npm install, but I got some kind of error ("UNMET PEER DEPENDENCY eslint-plugin -react@5.0.1 extraneous".

I tried to search for this error in the internet, but I didn't find anything useful. So I updated my node.js to the newest version and I also installed eslint-plugin-react via cmd and after this npm install worked:

img

After this I wrote not valid code, checked it with the help of npm run lint, it said that there are some errors and I tried to commit this file, and commit worked even with lint problems:

img

DeuceX commented 8 years ago

Done

nesterone commented 8 years ago

Looks like you have some side effect after merging pre-commit hook, because some of your exercises got conflicts with DeuseX branch in my repo