search

nestharus / JASS

MIT License
31 stars 8 forks source link

Trigger out of date #28

Open Serenity09 opened 7 years ago

Serenity09 commented 7 years ago

Your Event library that depends on Trigger tries to call the Trigger struct's create with no arguments. Right now, the Trigger file only has a constructor definition with 1 argument, reversed

https://github.com/nestharus/JASS/blob/master/jass/Systems/Event/script.j, lines 42-45 https://github.com/nestharus/JASS/blob/master/jass/Systems/Trigger/script.j, line 473

Serenity09 commented 7 years ago

Oh I see, you're kindof inactive. Well I'm betting that your pride won't let your stable branch have compile-time errors. I think it's fine if you just provide a 2nd constructor without params for now, until you can refactor them properly.

Oh wait, there's no overloading, I'm so glad I've come back to this language