search

nestjs / azure-func-http

Azure Functions HTTP adapter for Nest framework (node.js) 🌥
https://nestjs.com/
MIT License
151 stars 42 forks source link

Add compatibility with the @nestjs/fastify-adaptor #250

Open Jefftopia opened 4 years ago

Jefftopia commented 4 years ago

I'm submitting a...


[ ] Regression 
[ X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

I am not sure if this is a bug, or a feature request.

Current behavior

  1. git clone https://github.com/TrilonIO/nestjs-azure-functions - the azure func demo app.
  2. npm install --save @nestjs/platform-fastify
  3. npm install the rest.
  4. Swap the default express adaptor with the fastify one.
  5. Make sure you have Azure's func cli installed, then npm run build && func host start.
  6. Open a valid endpoint. In this case, the url logged when func host start has completed and the server is running.

Expected behavior

Fastify should have the same 200 success response as Express adaptor.

Minimal reproduction of the problem with instructions

See instructions above.

What is the motivation / use case for changing the behavior?

I'd like to use Fastify with Azure functions as it's lighter weight and faster.

Environment

MacOS Catalina NodeJS: 12.16.3

NestJS common, core: 7.0.8 NestJS platform-fastify 7.0.11 @nestjs/azure-func-http: 0.5.0 @azure/functions: 1.0.3

Others: npm VSCode zsh

Jefiozie commented 4 years ago

Hi @kamilmysliwiec is this something that we should add to this package? If so I think I will have some time to implement it.

Let me know what you think and if I need to know about some specific stuff around fastify

kamilmysliwiec commented 4 years ago

@Jefiozie course! If you have some spare time, that would be awesome :)

niklas-wortmann commented 2 years ago

Hi everybody, is there any news about this? Could make use of this in one of my projects. Btw. you guys are doing an awesome job!

tastafur commented 1 year ago

still not working, it would be cool if we could make it work