nestjs / azure-storage

Azure Storage module for Nest framework (node.js) ☁️
https://nestjs.com
MIT License
87 stars 35 forks source link

ci(): use next-gen convenience image; update npm version without sudo #310

Closed wodCZ closed 2 years ago

wodCZ commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The build page at circleci displays the following notice:

You’re using a deprecated Docker convenience image. Upgrade to a next-gen Docker convenience image.

Following the article we can see that the current images are no longer supported and no updates will be published.

Dec 31, 2021 - Legacy Convenience Images are no longer supported. This will be the last publishing day of these images. Existing tags will still exist on Docker Hub but will remain unchanged. There will be no support for bug or security fixes for existing tags. No new tags will be published after this day.

Issue Number: N/A

What is the new behavior?

The recommended convenience images are used and the deprecation warning is no longer displayed.

The previous image was pinned on Node.js v16.*. The new images don't support major-only version pinning and require an explicit minor version, 16.15 as of now (see github repo).

I couldn't find a list of changes between circleci/node and cimg/node, the only reference I found says it's a direct replacement.

Does this PR introduce a breaking change?

kamilmysliwiec commented 2 years ago

lgtm