registerAsync + global does not work

JacobSiegle commented 3 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior

The modules providers are not found even though the module is specified as global.

Minimum reproduction code

https://stackblitz.com/edit/nestjs-typescript-starter-j7sze2?file=src%2Fapp.module.ts&terminal=start

Steps to reproduce

Stackblitz - Error: Nest can't resolve dependencies of the SubService (?). Please make sure that the argument "CACHE_MANAGER" at index [0] is available in the SubModule context.

Potential solutions:

Is SubModule a valid NestJS module?
If "CACHE_MANAGER" is a provider, is it part of the current SubModule?
If "CACHE_MANAGER" is exported from a separate @Module, is that module imported within SubModule? @Module({ imports: [ / the Module containing "CACHE_MANAGER" / ] })

Expected behavior

The modules providers work like register

Package version

2.2.1

NestJS version

10.3.1

Node.js version

18

In which operating systems have you tested?

[ ] macOS
[ ] Windows
[ ] Linux

Other

No response

kamilmysliwiec commented 3 months ago

JacobSiegle commented 3 months ago

@kamilmysliwiec Thanks!

useFactory?: (...args: any[]) => Promise<CacheModuleOptions> | CacheModuleOptions;

CacheModuleOptions has isGlobal when using registerAsync, I noticed you closed but do you think the type is worth fixing?

kamilmysliwiec commented 3 months ago

Oh yeah it is! Would you like to create a PR?

nestjs / cache-manager