fix(type): CacheModuleAsyncOptions - Githubissues

nestjs / cache-manager

Cache manager module for Nest framework (node.js) 🗃

MIT License

114 stars 20 forks source link

fix(type): CacheModuleAsyncOptions #351

Closed JacobSiegle closed 3 months ago

JacobSiegle commented 3 months ago

Reused type CacheModuleOptions causing isGlobal to leak incorrectly into async options.

https://github.com/nestjs/cache-manager/issues/349

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

isGlobal incorrectly appears in the config options for CacheModuleAsyncOptions

Issue Number: https://github.com/nestjs/cache-manager/issues/349

What is the new behavior?

isGlobal is removed from the type

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

kamilmysliwiec commented 3 months ago

lgtm