search

nestjs / cache-manager

Cache manager module for Nest framework (node.js) 🗃
MIT License
126 stars 26 forks source link

Outdated Redis Cache examples #491

Closed karlismelderis-mckinsey closed 2 weeks ago

karlismelderis-mckinsey commented 2 months ago

Is there an existing issue for this?

Current behavior

Please replace cache-manager-redis-store with cache-manager-redis-yet

https://docs.nestjs.com/techniques/caching#different-stores https://github.com/nestjs/cache-manager/blob/master/package.json#L34C6-L34C31

cache-manager-redis-store is old, doesn't feel to be maintained and has a bug that probably won't get fixed: https://github.com/nestjs/cache-manager/issues/74

it's better to use cache-manager official Redis store in your examples and dependencies

Minimum reproduction code

N/A

Steps to reproduce

No response

Expected behavior

Docs and cache library dependencies updated

Package version

2.2.2

NestJS version

9.x

Node.js version

No response

In which operating systems have you tested?

Other

No response

karlismelderis-mckinsey commented 2 months ago

Also you will be able to remove warning from the docs as cache-manager-redis-yet uses redis v4 package

arketec commented 1 month ago

Also, cache-manager no longer exports Cache interface as of v6, but the docs example includes this

although this project's peerDependencies state <=5, so not sure that will be updated as well

xavierraffin commented 1 month ago

@arketec I created a ticket specifically on that problem: https://github.com/nestjs/cache-manager/issues/516

kamilmysliwiec commented 2 weeks ago

Fixed