nestjs / javascript-starter

Nest framework JavaScript (ES6, ES7, ES8) + Babel starter 🍰
https://nestjs.com/
117 stars 26 forks source link

Added the missing License File #28

Closed marsonya closed 3 years ago

marsonya commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe:

What is the current behavior?

The License file link is available in the README.md file. But it's a dead link. The License file doesn't exist.

What is the new behavior?

Added the missing License File.

Does this PR introduce a breaking change?

[ ] Yes
[x] No
kamilmysliwiec commented 3 years ago

As this is a template project (to be used for developers apps), I don't think we should be adding a LICENSE file here.

marsonya commented 3 years ago

As this is a template project (to be used for developers apps), I don't think we should be adding a LICENSE file here.

That sounds right. But in that case, should we remove the License Section in the README.md file? Right now the license link provided in the README.md file opens a 404 page.

kamilmysliwiec commented 3 years ago

@marsonya sounds good! just removed