Improper dev dependencies for contributors

Ginden commented 3 years ago

I'm submitting a...


[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

npm run lint throws with:

Error: Cannot read config file: /home/ginden/Projects/open-source/mongoose/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: /home/ginden/Projects/open-source/mongoose/.eslintrc.js

Expected behavior

It lints.

Minimal reproduction of the problem with instructions

git clone git@github.com:nestjs/mongoose.git;
cd mongoose;
npm ci;
npm run lint

What is the motivation / use case for changing the behavior?

I want to resolve #1014

Environment

For Tooling issues:

Node version: v16.5.0
Platform: Linux, Ubuntu 20 LTS
npm --version: 7.19.1

kamilmysliwiec commented 3 years ago

Would you like to create a PR to address this issue?