nestjs / nest-cli

CLI tool for Nest applications 🍹
https://nestjs.com
Other
1.98k stars 395 forks source link

fix: show type check warning only when builder is not swc #2792

Closed kamilmysliwiec closed 1 week ago

kamilmysliwiec commented 3 weeks ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2791

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

gterras commented 3 weeks ago

Will try to look at it soon !

gterras commented 1 week ago

LGTM thank you, btw is there a contributor guide available somewhere since I couldn't find a non-cumbersome way to test this locally ?