ConfigurableModuleClass registerAsync wrongly generates empty imports

[tbglazer]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current behavior

ConfigurableModuleClass super.registerAsync() generates empty imports:[] overriding any imports existing before.

Minimum reproduction code

no reproduction code

Steps to reproduce

No response

Expected behavior

Should not generate empty imports. As a workaround call ...super.registerAsync() before adding any imports (unlike the documentation)

Package

• [ ] I don't know. Or some 3rd-party package
• [X] code>@nestjs/common</code
• [X] code>@nestjs/core</code
• [ ] code>@nestjs/microservices</code
• [ ] code>@nestjs/platform-express</code
• [ ] code>@nestjs/platform-fastify</code
• [ ] code>@nestjs/platform-socket.io</code
• [ ] code>@nestjs/platform-ws</code
• [ ] code>@nestjs/testing</code
• [ ] code>@nestjs/websockets</code
• [ ] Other (see below)

Other package

No response

NestJS version

9.3.6

Packages versions

Node.js version

No response

In which operating systems have you tested?

• [ ] macOS
• [X] Windows
• [ ] Linux

Other

No response

[micalevisk]

I didn't manage to reproduce this.

Please provide a minimum reproduction repository. You can start from this minimal project.

why reproductions are required

[tbglazer]

Hi, I made a minimal reproduction at : https://github.com/tbglazer/nestjs-dynamic-module-bug.git Clone it and start it : npm run start In the output you can see that the registerAsync as compared to register generates an empty imports that is not needed and overrides any imports defined before. As a workaround you can spread the super.registerAsync() BEFORE any other code.

[image: image.png]

On Sat, Feb 11, 2023 at 4:57 PM Micael Levi L. Cavalcante < @.***> wrote:

I didn't manage to reproduce this.

Please provide a minimum reproduction repository. You can start from this minimal project https://stackblitz.com/edit/nestjs-issue-minimum-repro-starter?devtoolsheight=33 . why reproductions are required https://antfu.me/posts/why-reproductions-are-required

— Reply to this email directly, view it on GitHub https://github.com/nestjs/nest/issues/11097#issuecomment-1426792094, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANFZEGP3S4YPSVQYGZJ4OD3WW6SDXANCNFSM6AAAAAAUYUROOQ . You are receiving this because you authored the thread.Message ID: @.***>

[kamilmysliwiec]

This is the expected behavior.

Please, use our Discord channel (support) for such questions. We are using GitHub to track bugs, feature requests, and potential improvements.