Middleware applied twice using setGlobalPrefix excluding route "/"

[alucebur]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current behavior

Middleware is applied twice when using setGlobalPrefix with the route "/" excluded, for every route except "/".

Minimum reproduction code

https://codesandbox.io/p/sandbox/determined-ben-7357wt

Steps to reproduce

There are 4 routes; three of them are prefixed by "api" global prefix, and one is excluded ("/").

• /
• /api/two
• /api/one
• /api/one/one

There is a middleware that logs the request, showing baseUrl and originalUrl from the petition.

When calling "/" route, middleware is executed once.

When calling any other route, middleware is executed twice, the last of them with baseUrl empty (check logs in the terminal).

If we edit the excluded route from "/" to "one", everything works as expected, being the middleware only executed once for every route.

Expected behavior

When setting a global prefix and excluding the route "/", the middleware is executed only once for every route in the application.

Package

• [ ] I don't know. Or some 3rd-party package
• [ ] code>@nestjs/common</code
• [X] code>@nestjs/core</code
• [ ] code>@nestjs/microservices</code
• [ ] code>@nestjs/platform-express</code
• [ ] code>@nestjs/platform-fastify</code
• [ ] code>@nestjs/platform-socket.io</code
• [ ] code>@nestjs/platform-ws</code
• [ ] code>@nestjs/testing</code
• [ ] code>@nestjs/websockets</code
• [ ] Other (see below)

Other package

No response

NestJS version

10.0.0

Packages versions

{
  "name": "nest-typescript-starter",
  "private": true,
  "version": "1.0.0",
  "description": "Nest TypeScript starter repository",
  "license": "MIT",
  "scripts": {
    "build": "nest build",
    "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
    "start": "nest start",
    "start:dev": "nest start --watch",
    "start:debug": "nest start --debug --watch",
    "start:prod": "node dist/main",
    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
    "test": "jest",
    "test:watch": "jest --watch",
    "test:cov": "jest --coverage",
    "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
    "test:e2e": "jest --config ./test/jest-e2e.json"
  },
  "dependencies": {
    "@nestjs/common": "^10.0.0",
    "@nestjs/core": "^10.0.0",
    "@nestjs/platform-express": "^10.0.0",
    "reflect-metadata": "^0.1.13",
    "rxjs": "^7.8.1"
  },
  "devDependencies": {
    "@nestjs/cli": "^10.0.1",
    "@nestjs/schematics": "^10.0.1",
    "@nestjs/testing": "^10.0.0",
    "@swc/cli": "^0.1.62",
    "@swc/core": "^1.3.64",
    "@types/express": "^4.17.17",
    "@types/jest": "^29.5.2",
    "@types/node": "^20.3.1",
    "@types/supertest": "^2.0.12",
    "@typescript-eslint/eslint-plugin": "^5.59.11",
    "@typescript-eslint/parser": "^5.59.11",
    "eslint": "^8.42.0",
    "eslint-config-prettier": "^8.8.0",
    "eslint-plugin-prettier": "^4.2.1",
    "jest": "^29.5.0",
    "prettier": "^2.8.8",
    "source-map-support": "^0.5.21",
    "supertest": "^6.3.3",
    "ts-jest": "^29.1.0",
    "ts-loader": "^9.4.3",
    "ts-node": "^10.9.1",
    "tsconfig-paths": "^4.2.0",
    "typescript": "^5.1.3"
  },
  "jest": {
    "moduleFileExtensions": [
      "js",
      "json",
      "ts"
    ],
    "rootDir": "src",
    "testRegex": ".*\\.spec\\.ts$",
    "transform": {
      "^.+\\.(t|j)s$": "ts-jest"
    },
    "collectCoverageFrom": [
      "**/*.(t|j)s"
    ],
    "coverageDirectory": "../coverage",
    "testEnvironment": "node"
  }
}

Node.js version

16.17.0

In which operating systems have you tested?

• [ ] macOS
• [ ] Windows
• [X] Linux

Other

The issue has also been reproduced using Nest v9.4 and Node 18, under WSL.

[micalevisk]

this seems to be a regression introduced on PR #10390 (v9.3.2)

v9.3.0 went fine

[kamilmysliwiec]

Would you like to create a PR for this issue?

[kamilmysliwiec]

Let's track this here https://github.com/nestjs/nest/pull/11832

[jr-dimedis]

Any plan to merge the referenced PR? I hit this bug and was happy to see that there is a fix available but unfortunately it's not released yet.

Thanks!

[jonasnilsberg]

Any updates on this?