[Discussion] merge with Dandi?

[DanielSchaffer]

I'm submitting a...

[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Hello everyone, I'm the author of Dandi, which is a very similar project I started on my own a while back. Someone on Reddit suggested that my efforts might be better spent joining Nest instead, so here I am!

It seems like we've done a lot of similar things, and certain parts of our respective projects may be more complete than others. It also seems like the structure of my project may be of some relevance given the discussions currently happening in #1065.

Since Nest is clearly already established, I'd love to discuss which parts of Dandi you may be interested in porting to Nest, and how it would make sense to go about doing so.

To give a brief intro to the structure of my project - it is a monorepo, structured similarly to Angular. @dandi/core is only used for DI, and in theory, could even be used in the browser. The other member packages incrementally add on capabilities. For example, @dandi/mvc defines an MVC framework, but relies on other packages like @dandi/mvc-express for providing the actual HTTP server functionality. There are modeling and validation utilities in @dandi/model and @dandi/model-builder, as well as a handful of other packages for integrating with common backend services (postgres, firebase auth, aws ssm)

[kamilmysliwiec]

Hi @DanielSchaffer, Nest is widely used across many production applications already and, as you pointed out, is established in the node.js space. Therefore, any merge with other frameworks/libraries is not applicable and will not be considered. However, we're always open to new ideas, features, and tooling that would give more efficiency and increase the productivity of framework's users, making Nest even more comprehensive in comparison to any other existing ecosystem. If you want to port a feature that you would like to see in nest, I'd suggest creating a separated issue for each of them, so we can work on them separately :)

[BrunnerLivio]

@DanielSchaffer it takes courage to reach out to us and offer your generosity! Thanks for being a good sports! Peeking through your source code I found in my opinion a really clean code base. I really try to push NestJS forward to a more modular structure, similar to yours. As @kamilmysliwiec our hands are tied with merging two frameworks together. We have tons of tests, documentation and public API, which we have to maintain as good as possible. That is why we can only accept smaller to medium-ish PRs.

Nonetheless I would gladly see you join the discussion with #1065 & #531 and share your experiences :)

[DanielSchaffer]

@BrunnerLivio thank you for the kind words. I’m afraid you may have mistaken my intention - I realize that attempting to merge my code wholesale is a non-starter. I’d expect anything I bring to you to either be incremental, or more likely, in the form of additional, complimentary packages. Since I’m not familiar with Nest, I was hoping to discuss where to start - perhaps features I have in Dandi that aren’t yet included in Neat.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.